I came across this in a live Workflow the other day:
What’s happening here is that the comparison of two Workflow Process properties is being done in a custom, eScript Business Service. Further digging revealed that the ‘Is Num >= Max?’ step invoked the following eScript:
function GreaterThanOrEqual(Inputs, Outputs)
{
var res = "Y";
var val1 = new Number(Inputs.GetProperty("Value1"));
var val2 = new Number(Inputs.GetProperty("Value2"));
if (val1 >= val2)
{
res = "Y";
}
else
{
res = "N";
}
Outputs = res;
return (Outputs);
}
Apart from the obvious problems with this code, it struck me as a very round about way to compare two properties within a Workflow.
So I replaced it all with a single, expression based decision step:
Does anyone have any examples of their own of ‘over engineered’ solutions to simple problems?
